Repository navigation
Conversation
This was referenced Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR and its sister PR in
ogiroux/libcxxencapsulate the changes necessary to use the C++17type_traitsand C++20 chrono calendars in cudf with the-std=c++14flag.C++17 type_traits
25eb5eb makes the following modifications:
_LIBCPP_HAS_NO_IS_AGGREGATEin__configtype_traitsinclude in block with_LIBCPP_STD_VERredefined to 17C++20 chrono calendars
This task was more involved, and I couldn't get it working without also modifying
ogiroux/libcxx._LIBCPP_INLINE_CONSTEXPRmacro to replace theinline constexprvariable declarations withstatic constexpr__ratio_multiplyand__ratio_dividemembers public, which was the only solution I found to these compiler errors. Open to suggestions on a better fix here.hh_mm_ssimplementation, which was the only solution I found to these compiler errors.hh_mm_ssimpl looks different from the latest version inHowardHinnant/date. IfHowardHinnant/dateis the C++20 reference impl, upgrading to the latest may be a solution.system_clockintolibcxxdirectly, because the subsequent types rely onsys_timealready being defined.chronoinclude in a block with_LIBCPP_STD_VERredefined to 20, and undefines_LIBCPP_HAS_CLOCK_API_EXTERNAL.time_point, but couldn't get it to compile. This is probably the nastiest change, so I'm open to alternative fixes here too.